Jackie-Jiang commented on code in PR #17601:
URL: https://github.com/apache/pinot/pull/17601#discussion_r2761302555
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -102,27 +104,44 @@ public class PluginManager {
}
};
- private static final Map<String, String>
INPUT_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
- new HashMap<String, String>() {
+ private static final Map<FileFormat, String>
FILE_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
Review Comment:
Based on my understanding (maybe I was wrong), the issue is from translating
from String `inputFormat` to `FileFormat`. So my suggestion is to add the
`INPUT_FORMAT_TO_FILE_FORMAT_MAP`, and keep the existing map as is so that we
don't need to do 2 hops lookup, and the lookup is always from `inputFormat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
