anshul98ks123 commented on code in PR #17601:
URL: https://github.com/apache/pinot/pull/17601#discussion_r2757762198
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -102,27 +104,44 @@ public class PluginManager {
}
};
- private static final Map<String, String>
INPUT_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
- new HashMap<String, String>() {
+ private static final Map<FileFormat, String>
FILE_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
Review Comment:
didn't get you
How does a mapping between inputFormat and fileformat help if we keep only
PROTO in fileformat?
both PluginManager and RecordReaderFactory get the same input
and to keep both PluginManager and RecordReaderFactory aligned, we'd need to
keep either two entries in PluginManager -> "proto" (new) and "protobuf (keep
existing)
or just change "protobuf" to "proto"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
