Akanksha-kedia commented on code in PR #18472:
URL: https://github.com/apache/pinot/pull/18472#discussion_r3387426394
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -220,20 +212,16 @@ public TableConfigBuilder
setLineageEntryCleanupRetentionPeriod(String lineageEn
/**
* @deprecated Use {@code segmentIngestionType} from {@link
IngestionConfig#getBatchIngestionConfig()}
*/
+ @Deprecated
public TableConfigBuilder setSegmentPushType(String segmentPushType) {
- if (REFRESH_SEGMENT_PUSH_TYPE.equalsIgnoreCase(segmentPushType)) {
- _segmentPushType = REFRESH_SEGMENT_PUSH_TYPE;
- } else {
- _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
- }
return this;
Review Comment:
Updated — the latest commit adds the write-through to `BatchIngestionConfig`
in `build()`. When either `_segmentPushType` or `_segmentPushFrequency` is set
and no `BatchIngestionConfig` exists yet, `build()` now creates one with those
values. This ensures consumers reading
`IngestionConfig.getBatchIngestionConfig()` see the correct values.
The existing write to `validationConfig` is kept for backward compat with
the `IngestionConfigUtils` legacy fallback. @Jackie-Jiang @xiangfu0 could you
re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
