Akanksha-kedia commented on PR #18472: URL: https://github.com/apache/pinot/pull/18472#issuecomment-4769587056
Rebased and squashed to a single clean commit on current `master` (was carrying 13 upstream commits in the branch history — those are now gone, so the diff is much smaller: 6 files, +102/-13). **Summary of what the single commit does:** - Keeps `setSegmentPushType()` / `setSegmentPushFrequency()` functional (not no-ops) - `build()` propagates `REFRESH` push type and non-null frequency into `BatchIngestionConfig` — the canonical location per @Jackie-Jiang's guidance - Merge rules: if a `BatchIngestionConfig` already exists, only `null` fields are filled in, so an explicit `setIngestionConfig()` always wins - Default `APPEND` type is **not** propagated to avoid creating a spurious `BatchIngestionConfig` on REALTIME tables - The existing write to `SegmentsValidationAndRetentionConfig` is kept for `IngestionConfigUtils` backward compat **Tests:** `TableConfigBuilderTest` — 5 tests, all pass (including 4 new scenarios for the write-through) @Jackie-Jiang @xiangfu0 — would really appreciate a re-review when you get a chance, the diff should be much cleaner now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
