Akanksha-kedia commented on PR #18472: URL: https://github.com/apache/pinot/pull/18472#issuecomment-4815943237
@xiangfu0 and @Jackie-Jiang — following up on this PR. The last three commits (2026-06-09, 2026-06-10, 2026-06-16) address your feedback: - The deprecated setters no longer silently swallow data; they now write-through to `BatchIngestionConfig` in `build()` - The write-through handles both cases: when no `BatchIngestionConfig` exists yet (creates one), and when one already exists (merges the legacy fields into it) - All CI checks pass on the latest commit Would appreciate another look when you get a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
