Akanksha-kedia commented on PR #18472: URL: https://github.com/apache/pinot/pull/18472#issuecomment-4767928532
Thanks @Jackie-Jiang and @xiangfu0 for the review! Updated the PR: the deprecated setters now forward non-default values to `BatchIngestionConfig` in `build()` instead of writing only to the legacy `validationConfig` path. Key changes: - `REFRESH` push type and non-null frequency are propagated to `BatchIngestionConfig`; the default `APPEND` is intentionally not propagated to avoid adding a spurious `BatchIngestionConfig` to REALTIME tables that never called these setters - Explicit `IngestionConfig` set via `setIngestionConfig()` takes precedence — existing non-null fields are not overwritten - Added `TableConfigBuilderTest` cases covering all four scenarios -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
