xiangfu0 commented on PR #18185: URL: https://github.com/apache/pinot/pull/18185#issuecomment-4964753976
Rebased onto current `master` and force-pushed commit `8481abd2c4`. CI fix: - Clear `LARGEST_SEGMENT_SIZE_ON_SERVER` when a size sample has no valid segment response, so an earlier successful read cannot leave a stale gauge. - Make the all-error regression deterministic by pre-seeding the stale gauge and asserting that it is removed. Validation completed locally: - `TableSizeReaderTest`, `TableSizeReaderCompressionStatsTest`, and `SegmentStatusCheckerTest`: 55 tests passed. - Exact post-rebase CI regression: passed. - Spotless, Checkstyle, and license checks for `pinot-controller`: passed. All review threads are resolved (0 unresolved), the PR remains approved and mergeable, and the refreshed CI run is now in progress. The two previous compatibility failures against `master` were Kafka distribution mirror download timeouts rather than code failures; this push reruns them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
