xiangfu0 commented on code in PR #19247:
URL: https://github.com/apache/pinot/pull/19247#discussion_r3781157267
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -258,6 +258,9 @@ public static Literal getLiteral(SqlLiteral node) {
case NULL:
literal.setNullValue(true);
break;
+ case BINARY:
Review Comment:
Addressed in 5baa772117: the BINARY branch now appears immediately before
NULL in RequestUtils.getLiteral(SqlLiteral).
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java:
##########
@@ -132,6 +132,14 @@ public static Object convert(Object value, ColumnDataType
storedType) {
// For ArrayAggregationFunction
return ArrayListUtils.toBytesArray((ObjectArrayList<ByteArray>)
value);
}
+ if (value instanceof byte[][]) {
+ byte[][] bytesArray = (byte[][]) value;
+ ByteArray[] internalBytesArray = new ByteArray[bytesArray.length];
+ for (int i = 0; i < bytesArray.length; i++) {
+ internalBytesArray[i] = new ByteArray(bytesArray[i]);
+ }
+ return internalBytesArray;
Review Comment:
Addressed in 265911bed5: TypeUtilsTest.testConvertBytesArray directly
exercises byte[][] to ByteArray[] normalization and verifies empty,
single-byte, multi-byte, and 0xFF content. The focused 20-module reactor and
all pinot-query-runtime pre-commit checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
