xiangfu0 commented on code in PR #19247:
URL: https://github.com/apache/pinot/pull/19247#discussion_r3847994221
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -2116,6 +2116,20 @@ private void computeResultsForExpression(Expression
expression, String[] columnN
List<Expression> operands = function.getOperands();
computeResultsForExpression(operands.get(0), columnNames, columnTypes,
values, index);
columnNames[index] = operands.get(1).getIdentifier().getName();
+ } else if (operator.equals("arrayvalueconstructor")) {
Review Comment:
You are right. I over-indexed on old-reader wire compatibility here. A
pre-change server can deserialize the constructor scalar `binaryValue`
operands, but its `ArrayLiteralTransformFunction` has no `BYTES` case, so it
still cannot execute a `BYTES_ARRAY` literal. Because the feature itself
therefore requires upgraded servers, retaining the constructor does not provide
usable rolling-upgrade compatibility; it only adds a different failure path. I
will fold `byte[][]` into the new `bytesArrayValue` Thrift arm like the other
arrays, remove the broker `arrayValueConstructor` special case, and update the
compatibility test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
