xiangfu0 commented on code in PR #19247:
URL: https://github.com/apache/pinot/pull/19247#discussion_r3848145809
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -2116,6 +2116,20 @@ private void computeResultsForExpression(Expression
expression, String[] columnN
List<Expression> operands = function.getOperands();
computeResultsForExpression(operands.get(0), columnNames, columnTypes,
values, index);
columnNames[index] = operands.get(1).getIdentifier().getName();
+ } else if (operator.equals("arrayvalueconstructor")) {
Review Comment:
Implemented in 31ff773e69. BYTES_ARRAY now folds into the native Thrift
bytesArrayValue arm, matching the other array literal types. I removed the
CompileTimeFunctionsInvoker constructor fallback, the broker
arrayValueConstructor special case, and the literal-only parser exception.
Tests assert native field 17 through SQL compilation and compact-protocol
round-trip; LiteralOnlyBrokerRequestTest passes on the generic broker path; and
BytesMvTypeTest passed all four selected cases across both engines, including
ingestion/query for dictionary and raw MV BYTES columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
