siddharthteotia commented on PR #8953: URL: https://github.com/apache/pinot/pull/8953#issuecomment-1169368374
> > looks good to me overall. I think some of the code paths are not covered in unit tests. I watched some but it would be nice to cover a bit more > > if the other 2 PRs that are following this one is going to cover those then nvm. > > Yes I have much more exhaustive tests in the other PRs. I'll send out the next one as soon as this one is merged. Hope that's okay yes @walterddr - the original PR https://github.com/apache/pinot/pull/8917 by @somandal where this piece was split from has all comprehensive tests. When the split was done, splitting tests was not super straightforward. When the final split is merged, all remaining tests will be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
