[GitHub] [pinot] somandal commented on a diff in pull request #8953: Add multi-value noDict APIs and their implementation for querying immutable and mutable fixed-width segment types

[GitBox]

somandal commented on code in PR #8953:
URL: https://github.com/apache/pinot/pull/8953#discussion_r909089594


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/fwd/MultiValueFixedByteRawIndexCreator.java:
##########
@@ -77,7 +77,8 @@ public MultiValueFixedByteRawIndexCreator(File baseIndexDir, 
ChunkCompressionTyp
       boolean deriveNumDocsPerChunk, int writerVersion)
       throws IOException {
     File file = new File(baseIndexDir, column + 
Indexes.RAW_MV_FORWARD_INDEX_FILE_EXTENSION);
-    int totalMaxLength = maxNumberOfMultiValueElements * 
valueType.getStoredType().size();
+    // Store the length followed by the values
+    int totalMaxLength = Integer.BYTES + (maxNumberOfMultiValueElements * 
valueType.getStoredType().size());

Review Comment:
   I don't think this code path was tested correctly (especially on the read 
path for non-integer types). I only ran into issues (I believe it was a buffer 
overflow) when I tried LONG and DOUBLE type columns. Then spent time 
understanding what the code does and realized that the size is missing.
   
   And just to note, this class correctly sets the length. It just didn't 
account for it in the size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org