[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8953: Add multi-value noDict APIs and their implementation for querying immutable and mutable fixed-width segment types

[GitBox]

siddharthteotia commented on code in PR #8953:
URL: https://github.com/apache/pinot/pull/8953#discussion_r909233038


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/fwd/MultiValueFixedByteRawIndexCreator.java:
##########
@@ -77,7 +77,8 @@ public MultiValueFixedByteRawIndexCreator(File baseIndexDir, 
ChunkCompressionTyp
       boolean deriveNumDocsPerChunk, int writerVersion)
       throws IOException {
     File file = new File(baseIndexDir, column + 
Indexes.RAW_MV_FORWARD_INDEX_FILE_EXTENSION);
-    int totalMaxLength = maxNumberOfMultiValueElements * 
valueType.getStoredType().size();
+    // Store the length followed by the values
+    int totalMaxLength = Integer.BYTES + (maxNumberOfMultiValueElements * 
valueType.getStoredType().size());

Review Comment:
   Discussed this offline with @somandal . The MV writer caller wasn't doing 
the right thing and this change is needed. @somandal , it will be great if you 
can share the findings here for future reference. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org