somandal commented on code in PR #8953:
URL: https://github.com/apache/pinot/pull/8953#discussion_r909067857
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -496,4 +861,26 @@ default int getStringMV(int docId, String[] valueBuffer, T
context) {
default int getBytesMV(int docId, byte[][] valueBuffer, T context) {
throw new UnsupportedOperationException();
}
+
+ /**
+ * Reads the bytes type multi-value at the given document id.
+ *
+ * @param docId Document id
+ * @param context Reader context
+ * @return BYTE values at the given document id
+ */
+ default byte[][] getBytesMV(int docId, T context) {
Review Comment:
From my testing it looks like MV Bytes column type isn't supported today and
will need more work. I think support for `readBytesValues()` in `DataFetcher`
can be added when MV Bytes support is added. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
