walterddr commented on code in PR #10299:
URL: https://github.com/apache/pinot/pull/10299#discussion_r1110351153
##########
pinot-core/src/test/java/org/apache/pinot/core/query/reduce/StreamingReduceServiceTest.java:
##########
@@ -56,7 +56,7 @@ public void testThreadExceptionTransfer() {
threadPoolService,
ImmutableMap.of(routingInstance, mockedResponse),
1000,
- mock(BaseReduceService.ExecutionStatsAggregator.class));
+ mock(ExecutionStatsAggregator.class));
Review Comment:
could we add some test for both v1 and v2 engine for collecting and
aggregating stats via different metadata blocks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
