walterddr commented on code in PR #10299:
URL: https://github.com/apache/pinot/pull/10299#discussion_r1112099690
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OperatorStats.java:
##########
@@ -61,11 +63,14 @@ public void recordRow(int numBlock, int numRows) {
}
public void recordExecutionStats(Map<String, String> executionStats) {
- _statsAggregator.aggregate(executionStats);
+ _executionStats = executionStats;
}
public Map<String, String> getExecutionStats() {
- return _statsAggregator.getStats();
+ _executionStats.put(OperatorUtils.NUM_BLOCKS, String.valueOf(_numBlock));
+ _executionStats.put(OperatorUtils.NUM_ROWS, String.valueOf(_numRows));
+ _executionStats.put(OperatorUtils.WALL_TIME,
String.valueOf(_executeStopwatch.elapsed(TimeUnit.MILLISECONDS)));
Review Comment:
this is technically thread-time not WALL_TIME. let's change the naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
