walterddr commented on code in PR #10299:
URL: https://github.com/apache/pinot/pull/10299#discussion_r1113382185
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -83,14 +84,22 @@ public class AggregateOperator extends MultiStageOperator {
public AggregateOperator(MultiStageOperator inputOperator, DataSchema
dataSchema, List<RexExpression> aggCalls,
List<RexExpression> groupSet, DataSchema inputSchema, long requestId,
int stageId) {
this(inputOperator, dataSchema, aggCalls, groupSet, inputSchema,
AggregateOperator.Accumulator.MERGERS, requestId,
- stageId);
+ stageId, null);
+ }
+
+ public AggregateOperator(MultiStageOperator inputOperator, DataSchema
dataSchema, List<RexExpression> aggCalls,
Review Comment:
oh. i see. in this case lets make it clean -- there's no need to keep
additional public constructor just for test purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
