walterddr commented on code in PR #10299:
URL: https://github.com/apache/pinot/pull/10299#discussion_r1110352966


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OperatorStats.java:
##########
@@ -61,11 +61,11 @@ public void recordRow(int numBlock, int numRows) {
   }
 
   public void recordExecutionStats(Map<String, String> executionStats) {
-    _statsAggregator.aggregate(executionStats);
+    _executionStats = executionStats;

Review Comment:
   could we think of a way to incorporate `_numBlock` and `_numRows` in the 
executionStats?
   currently the executionStats is a Map which is generic enough, but the stats 
aggregator is still recognizing hard-coded keys for stats. should we add some 
that's only valid in V2 and some only valid in V1? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to