chenboat commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1552581249
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java:
##########
@@ -74,7 +85,8 @@ public static HashSet<String> getDefaultEnglishStopWordsSet()
{
* @param column column name
* @param segmentIndexDir segment index directory
* @param commit true if the index should be committed (at the end after all
documents have
- * been added), false if index should not be committed
+ * been added), false if index should not be
+ * @param sortedDocIds sortedDocIds from segment conversion
Review Comment:
same as my earlier comment on the naming. Also since this is a public
method, we need more explanation and some example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
