chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558086670
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ########## @@ -932,6 +932,19 @@ public Object getValue(int docId, String column) { } } + /** + * Calls commit() on all mutable indexes. This is used in preparation for realtime segment conversion. + * .commit() can be implemented per index to perform any required actions before using mutable segment + * artifacts to optimize imutable segment build. Review Comment: imutable --> immutable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org