chenboat commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1558134729
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##########
@@ -181,6 +181,17 @@ private MutableRoaringBitmap getPinotDocIds(IndexSearcher
indexSearcher, Mutable
return actualDocIDs;
}
+ @Override
+ public void commit() {
+ try {
+ _indexCreator.getIndexWriter().commit();
+ } catch (Exception e) {
+ LOGGER.error("Failed to commit the realtime lucene text index for column
{}, exception {}", _column,
+ e.getMessage());
Review Comment:
why not just log the error e?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
