itschrispeck commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1558835084
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java:
##########
@@ -90,14 +102,17 @@ public static HashSet<String>
getDefaultEnglishStopWordsSet() {
* to offline), we close this lucene index writer to release
resources but don't commit.
* @param config the text index config
*/
- public LuceneTextIndexCreator(String column, File segmentIndexDir, boolean
commit, TextIndexConfig config) {
+ public LuceneTextIndexCreator(String column, File segmentIndexDir, boolean
commit, boolean realtimeConversion,
+ @Nullable int[] immutableToMutableIdMap, TextIndexConfig config) {
_textColumn = column;
+
+ // to reuse the mutable index, it must be (1) not the realtime index, and
(2) is realtime segment conversion
Review Comment:
clarified in the code - `LuceneTextIndexCreator` is used for both in
`RealtimeLuceneTextIndex` and separately for the offline lucene text index. We
use the `commit` flag (set only for offline index) to avoid trying to convert
an index if the instance is created by `RealtimeLuceneTextIndex`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
