gortiz commented on code in PR #12704: URL: https://github.com/apache/pinot/pull/12704#discussion_r1565384127
########## pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java: ########## @@ -364,25 +357,6 @@ public void setStats(@Nullable String rawTableName, BrokerResponseNative brokerR } } - public void setStageLevelStats(@Nullable String rawTableName, BrokerResponseStats brokerResponseStats, - @Nullable BrokerMetrics brokerMetrics) { - if (_enableTrace) { - setStats(rawTableName, brokerResponseStats, brokerMetrics); - brokerResponseStats.setOperatorStats(_operatorStats); - } - - brokerResponseStats.setNumBlocks(_numBlocks); - brokerResponseStats.setNumRows(_numRows); - brokerResponseStats.setMaxRowsInJoinReached(_maxRowsInJoinReached); - brokerResponseStats.setNumGroupsLimitReached(_numGroupsLimitReached); - brokerResponseStats.setStageExecutionTimeMs(_stageExecutionTimeMs); - brokerResponseStats.setStageExecutionUnit(_stageExecutionUnit); - brokerResponseStats.setTableNames(new ArrayList<>(_tableNames)); - if (_stageExecStartTimeMs >= 0 && _stageExecEndTimeMs >= 0) { - brokerResponseStats.setStageExecWallTimeMs(_stageExecEndTimeMs - _stageExecStartTimeMs); - } - } - Review Comment: This method is not used anymore. Instead we merge stats in `MultiStageOperator.Type.mergeInto` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org