gortiz commented on code in PR #12704: URL: https://github.com/apache/pinot/pull/12704#discussion_r1565537934
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ########## @@ -240,6 +253,15 @@ protected boolean isEos(TransferableBlock element) { return element.isSuccessfulEndOfStreamBlock(); } + @Override + protected void onConsumerFinish(TransferableBlock element) { + if (element.getQueryStats() != null) { + _stats.mergeUpstream(element.getQueryStats()); + } else { + _stats.mergeUpstream(element.getSerializedStatsByStage()); Review Comment: By doing this we don't need to deserialize the stats when they are sent using memory mailboxes. But right now we are not prioritizing sending the stats there. That is something we can improve in future PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org