gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1565397287


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##########
@@ -88,6 +71,8 @@ public void onNext(MailboxContent mailboxContent) {
           LOGGER.warn("Mailbox: {} already cancelled from upstream", 
mailboxId);
           cancelStream();
           break;
+        case FIRST_ERROR:
+          return;

Review Comment:
   I added this enum to keep the same behavior in this class, which just 
aborted the execution when exceptions are found in a message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to