gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1565387972
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -64,25 +69,31 @@ public void send(TransferableBlock block)
return;
}
if (LOGGER.isDebugEnabled()) {
- LOGGER.debug("==[GRPC SEND]== sending data to: " + _id);
+ LOGGER.debug("==[GRPC SEND]== sending message " + block + " to: " + _id);
}
if (_contentObserver == null) {
_contentObserver = getContentObserver();
}
_contentObserver.onNext(toMailboxContent(block));
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("==[GRPC SEND]== message " + block + " sent to: " + _id);
+ }
Review Comment:
I've found this logs very useful to debug a concurrency issue in this PR.
All these logs are either not in the hot path or warded with `isDebugEnabled`
in order to do not allocate if disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
