flyrain commented on code in PR #158:
URL: https://github.com/apache/polaris/pull/158#discussion_r1737209922
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -288,7 +289,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
// different processes
// and in-memory state will be lost b/w invocation of bootstrap command
and running a server
if (metaStoreManagerFactory instanceof
InMemoryPolarisMetaStoreManagerFactory) {
-
metaStoreManagerFactory.getOrCreateMetaStoreManager(configuration::getDefaultRealm);
+
metaStoreManagerFactory.bootstrapRealms(List.of(configuration.getDefaultRealm()));
}
Review Comment:
Can we move this logic into class `InMemoryPolarisMetaStoreManagerFactory`
as a part of initialization? Actually it is already there, but deleted in this
PR. IIUC, here is the logic. We can make this change due to
`getOrCreateMetaStoreManager()` is invoked already before this line. In that
case, why do we need to bootstrap again here? We can bootstrap in the method
`InMemoryPolarisMetaStoreManagerFactory::getOrCreateMetaStoreManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
