aihuaxu commented on code in PR #158:
URL: https://github.com/apache/polaris/pull/158#discussion_r1737269708
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -288,7 +289,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
// different processes
// and in-memory state will be lost b/w invocation of bootstrap command
and running a server
if (metaStoreManagerFactory instanceof
InMemoryPolarisMetaStoreManagerFactory) {
-
metaStoreManagerFactory.getOrCreateMetaStoreManager(configuration::getDefaultRealm);
+
metaStoreManagerFactory.bootstrapRealms(List.of(configuration.getDefaultRealm()));
}
Review Comment:
I want to make the behavior the same regardless of InMemory or EclipseLink
so we can test against both with the same set of tests. We will not bootstrap
automatically but bootstrap if needed - we bootstrap in the tests for both
in-memory and EclipseLink and here in service against in-memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
