flyrain commented on code in PR #158:
URL: https://github.com/apache/polaris/pull/158#discussion_r1737288501
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -288,7 +289,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
// different processes
// and in-memory state will be lost b/w invocation of bootstrap command
and running a server
if (metaStoreManagerFactory instanceof
InMemoryPolarisMetaStoreManagerFactory) {
-
metaStoreManagerFactory.getOrCreateMetaStoreManager(configuration::getDefaultRealm);
+
metaStoreManagerFactory.bootstrapRealms(List.of(configuration.getDefaultRealm()));
}
Review Comment:
I understand that we want to explicitly bootstrap in test, which applies to
both in-memory and eclipse-link. But this place is a bit different. I was
wondering if there is a better way to handle bootstrapping here. Ideally, it
should be an internal operation within `InMemoryPolarisMetaStoreManagerFactory`.
##########
polaris-service/src/test/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandlerTest.java:
##########
@@ -43,15 +44,22 @@
import org.apache.polaris.core.entity.AsyncTaskType;
import org.apache.polaris.core.entity.TaskEntity;
import
org.apache.polaris.service.persistence.InMemoryPolarisMetaStoreManagerFactory;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
class ManifestFileCleanupTaskHandlerTest {
+ private InMemoryPolarisMetaStoreManagerFactory metaStoreManagerFactory;
+ RealmContext realmContext;
Review Comment:
make it private ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
