flyrain commented on code in PR #158:
URL: https://github.com/apache/polaris/pull/158#discussion_r1737212498
##########
polaris-service/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -48,40 +40,4 @@ protected PolarisMetaStoreSession createMetaStoreSession(
@NotNull PolarisTreeMapStore store, @NotNull RealmContext realmContext) {
return new PolarisTreeMapMetaStoreSessionImpl(store, storageIntegration);
}
-
- @Override
- public synchronized PolarisMetaStoreManager getOrCreateMetaStoreManager(
- RealmContext realmContext) {
- String realmId = realmContext.getRealmIdentifier();
- if (!bootstrappedRealms.contains(realmId)) {
- bootstrapRealmAndPrintCredentials(realmId);
- }
- return super.getOrCreateMetaStoreManager(realmContext);
- }
Review Comment:
I think it is the right place to bootstrap in-memory metastore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
