cbornet commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r922667321


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
     }
 
     private List<String> getDownloadCommand(Function.FunctionDetails 
functionDetails, String userCodeFilePath) {
-        if (Arrays.stream(PackageType.values()).anyMatch(type ->

Review Comment:
   Since we can download anyway the function itself directly, is there value to 
do it ?
   Can this be discussed and done in another PR ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to