cbornet commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r930134978
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
}
private List<String> getDownloadCommand(Function.FunctionDetails
functionDetails, String userCodeFilePath) {
- if (Arrays.stream(PackageType.values()).anyMatch(type ->
Review Comment:
Sorry to be insistent but this code [downloads the
package](https://github.com/apache/pulsar/blob/172a84624f47bb722e6b419de4e239fbb8ecc154/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java#L852)
using the admin client as the `downloadPackageFile` name of the function
suggests. It would be a bug if it were not so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
