cbornet commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r923529227


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
     }
 
     private List<String> getDownloadCommand(Function.FunctionDetails 
functionDetails, String userCodeFilePath) {
-        if (Arrays.stream(PackageType.values()).anyMatch(type ->

Review Comment:
   I see the value of package management.
   But in the context of downloading the code for a given Function, I don't see 
how using the CLI `functions download` command would return anything different 
than what is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to