cbornet commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r924193993
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
}
private List<String> getDownloadCommand(Function.FunctionDetails
functionDetails, String userCodeFilePath) {
- if (Arrays.stream(PackageType.values()).anyMatch(type ->
Review Comment:
> IIRC, the functions download will go for the files stored in Bookkeeper
DLog only, and will not download packages from the package management service.
No `functions download` will [download the
package](https://github.com/apache/pulsar/blob/172a84624f47bb722e6b419de4e239fbb8ecc154/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java#L1481)
when appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
