lhotari commented on PR #23874:
URL: https://github.com/apache/pulsar/pull/23874#issuecomment-2607342611

   > > > I think we'd better solve the issue this way, which has less lock 
range, better performance, and easier to read
   > > 
   > > 
   > > @poorbarcode thanks, I'll check the details to see if it addresses the 
issue.
   > 
   > @poorbarcode It fixes the test case in this PR, but it doesn't address 
another race condition that is possible. I'd have to come up with another test 
case that reproduces another possible race condition which would occur when 
there would be a race in an ordinary read and unblocking of a "draining" hash.
   > 
   > @poorbarcode It would be helpful if you could review the test framework 
improvement PRs #23875 and #23876 since I might need the read handle 
interceptor solution for introducing a race condition in a realistic scenario. 
The read handle interceptor solution is much cleaner than injecting behaviors 
with Mockito.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to