lhotari commented on code in PR #23874:
URL: https://github.com/apache/pulsar/pull/23874#discussion_r1926394378
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -335,6 +335,13 @@ public synchronized void readMoreEntries() {
}
return;
}
+ if (havePendingReplayRead) {
Review Comment:
Testing locally and came across a rare race condition where there are
duplicates which are considered out-of-order:
https://gist.github.com/lhotari/388188d17da881886768b42bbba01ac5#file-keysharedsubscriptiondisabledbrokercachetest-java-L445-L455
.
Key_Shared cannot prevent such issues alone, but I'm currently checking
whether this condition is more likely to happen when the havePendingReplayRead
changes are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
