lhotari commented on code in PR #23874:
URL: https://github.com/apache/pulsar/pull/23874#discussion_r1926397025
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -335,6 +335,13 @@ public synchronized void readMoreEntries() {
}
return;
}
+ if (havePendingReplayRead) {
Review Comment:
In any case, I'll move the havePendingReplayRead changes to another PR.
Reproducing the race condition referred to in the previous comment is hard to
reproduce and most likely reproducing would require introducing delays. The
PulsarMockBookKeeper read handle interceptor in #23875 would be useful for that
purpose. @poorbarcode Could you please review it in the mean time? It should be
a quick review to cover #23875 and #23876.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
