lhotari commented on PR #23874:
URL: https://github.com/apache/pulsar/pull/23874#issuecomment-2607355143

   > > I think we'd better solve the issue this way, which has less lock range, 
better performance, and easier to read
   > 
   > @poorbarcode thanks, I'll check the details to see if it addresses the 
issue.
   
   @poorbarcode Yes, it looks good. Great solution.
   
   Just thinking if a race could happen at that stage (in sending/dispatching) 
when a draining hash is unblocked: 
https://github.com/apache/pulsar/blob/e5bd77419e91d1602731cd0c1d02a738e1b7ebc7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java#L510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to