shohi commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r471198778



##########
File path: pulsar/producer_partition.go
##########
@@ -89,7 +88,7 @@ type partitionProducer struct {
        state  int32
        client *client
        topic  string
-       log    *log.Entry
+       logger log.Logger

Review comment:
       `log` is usually used for the package name, the logger is the one who 
does the logging job, i think it's more accurate using `logger` than `log`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to