shohi commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r474355182
##########
File path: pulsar/producer_partition.go
##########
@@ -89,7 +88,7 @@ type partitionProducer struct {
state int32
client *client
topic string
- log *log.Entry
+ logger log.Logger
Review comment:
Yeah, renaming makes the review scope bigger, but i don't think it's
hard to review, it's just a little annoying. The field name using `log` really
confuses me, perhaps it's better to open another PR for naming refactor, how
about putting a TODO marker first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
