ernado commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r474249200
##########
File path: pulsar/producer_partition.go
##########
@@ -89,7 +88,7 @@ type partitionProducer struct {
state int32
client *client
topic string
- log *log.Entry
+ logger log.Logger
Review comment:
`log` were selected initially by package maintainers, IMO there is no
reason to change naming in scope of this PR.
It is really hard to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
