shohi commented on pull request #323: URL: https://github.com/apache/pulsar-client-go/pull/323#issuecomment-678003212
> @shohi , please take a look at #354 > > 1. Reduced interface scope to single `Logger` > > 2. Allow `logrus.FieldLogger` as `NewLoggerWithLogrus` argument (this will allow passing logrus entries as new Logger so user can populate needed fields) > > 3. Use `log` instead of `logger` field name. > > > IMO we can rename `log` to `logger` in separate PR to reduce merge conflicts and PR scope. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
