hutiefang76 commented on PR #11271: URL: https://github.com/apache/seatunnel/pull/11271#issuecomment-5260406966
Addressed in `1ede24424`. I added reader-level coverage for both restore branches through `IncrementalSourceReader.addSplits()` and `pollNext()`: - when some tables remain, the reader queues the pruned split and snapshots only the retained table; - when all tables are removed, the reader queues nothing, does not request synchronously from `addSplits()`, and sends the next split request from the following `pollNext()`. I also added the suggested Javadoc to `IncrementalSplit.pruneTables(...)`. Verification: - counterfactual run against the old `addSplits()` behavior: 2 tests, 2 failures; - related CDC reader/split group: 10 tests, 0 failures; - full `connector-cdc-base` module: 60 tests, 0 failures; Spotless passed. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
