hutiefang76 commented on PR #11271: URL: https://github.com/apache/seatunnel/pull/11271#issuecomment-5386877953
Addressed the restore-path safety concern in e381b8ebe.\n\n- Captured-table discovery is attempted at most once per addSplits() batch.\n- If discovery throws, the restored incremental split is kept unchanged, so a transient database failure cannot fail recovery or discard checkpoint metadata.\n- If discovery returns an empty result for a non-empty restored split, pruning is skipped for the same reason.\n- Existing pruning remains in place when discovery returns a non-empty captured-table set.\n\nValidation on JDK 8:\n- ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base -Dtest=IncrementalSourceReaderTest test (4 tests, 0 failures/errors)\n- ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base test (73 tests, 0 failures/errors)\n\nThe regression coverage includes discovery failure, empty discovery, and one discovery call for a batch containing multiple restored incremental splits. Please let me know if a fresh review finds any remaining concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
