hutiefang76 commented on PR #11271: URL: https://github.com/apache/seatunnel/pull/11271#issuecomment-5369791785
Thanks for flagging this. The latest branch already skips empty round-robin buckets; I added a follow-up at 801c3d9628ebe9c134b513f63cb63d62d54b4bc1 for the other half of the restore path. When restored incremental splits are added back, their retained table ids are recorded in tableWatermarks. The assigner now removes those ids when computing both the remaining-table set and newly created incremental splits. Therefore, when a reader prunes its restored split to empty and requests another split, the enumerator does not recreate tables that are already being consumed from restored state. getRemainingTables also now reports completion correctly when every captured table is accounted for by restored state. Added shouldNotReassignTablesRestoredFromCheckpoint, alongside the existing empty-bucket coverage. Verified with JDK 8: ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base -Dtest=IncrementalSplitAssignerTest test Result: 4 tests, 0 failures/errors. Also passed: ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base spotless:check Could you please take another look at the unresolved thread? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
