DanielLeens commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5412549401
Thanks for the recap, @SEZ9 — your read of the delta since my last review is accurate: the only change on `a67ad2a93460eabf8f9e672b14fed6a0d926b126` since my round-4 comment is the `FakeSourceToConsoleWithEventReportIT` startup-wait extension, and everything else (license/dependency bookkeeping, the `close()` pool-eviction `finally`, the retry-path test) is unchanged from what I already re-traced and confirmed in earlier rounds. One correction on the CI front, since that's the one open item: I checked the fork run for this exact head directly rather than relying on the "Build" label — `goutamadwant/seatunnel` run `32676810603` (the one covering `a67ad2a93460eabf8f9e672b14fed6a0d926b126`) shows `conclusion: cancelled`, not a completed pass or fail. Every job in it, including `engine-v2-it` (the one that runs `FakeSourceToConsoleWithEventReportIT`, the test this round's fix targets), is `cancelled` rather than `success`/`failure`. So we still don't have an actual completed run to confirm the extended wait fixed the timeout — the run that would tell us that got cancelled before finishing, not "finished" as I'd read your message to suggest. @goutamadwant — could you push an empty commit or otherwise trigger a fresh run on this head so we get one that actually completes? Once `engine-v2-it` finishes (pass or fail) on this exact SHA, I'll take a final look. Nothing in the source review is blocking at this point — this is purely about getting a completed CI signal before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
