davidzollo commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5509606968
**CI diagnosis and status update (head `d98cfb60854b` → `6770a68d239d`)** I dereferenced the apache-side `Build` check pointer to the fork's real run (`abdessalems/seatunnel` run `33297052269`, head `d98cfb60854b`) and pulled the failing job logs directly: - All `unit-test` legs (JDK 8/11, Linux/Windows) and both `engine-v2-it` legs — the suites that actually exercise `TaskExecutionService`/Zeta worker-startup, the only production file this PR touches — passed. - `all-connectors-it-2 (8, ubuntu-latest)` failed on `CouchbaseIT.testFakeSourceToCouchbaseSink` (Couchbase test-container bootstrap failure), a known dev-wide infra flake unrelated to this PR's connector-doris/engine scope. - `doris-connector-it (11, ubuntu-latest)` failed on `DorisErrorIT.testDoris:85` (`expected: <true> but was: <false>`), a Doris-connector-specific assertion with no relationship to `TaskExecutionService` or the latch-release fix. - `all-connectors-it-6 (11, ubuntu-latest)` was cancelled (its JDK 8 counterpart passed). None of these three legs touch `seatunnel-engine-server` or any file changed by this PR. This matches @DanielLeens's own 09-01 review, which reached the same conclusion independently. I don't have write/admin access to `abdessalems/seatunnel` (fork collaborator check returns pull-only), so I can't trigger a job-level or run-level rerun directly. Since this PR's history already has precedent for using an empty commit to retrigger CI when a direct rerun isn't available (`17a98e1e1d`), I pushed an equivalent empty commit (`6770a68d239d`) via the maintainer-can-modify permission to get a fresh `Build` run started; no production or test code was touched. **Review status**: I read @DanielLeens's 09-01 full re-review and @SEZ9's 08-31 review end to end. Daniel's 09-01 pass already independently re-traced every one of SEZ9's F1–F8 findings against the current file and concluded "Ready to merge" with zero blocking items — the two non-blocking follow-ups (F5/Issue 1: a pre-existing redeploy-vs-cancel gap that predates this PR and is out of its stated scope; F7/Issue 2: a cosmetic reflection-based field access in the race test) are explicitly marked non-blocking and out of scope, so I made no source changes on their account. There are no unresolved inline review threads on this PR (all review feedback was posted as top-level review bodies). Net: no source or test changes from me on this pass — this PR's remaining gate is CI (now re-running) plus maintainer approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
