abdessalems commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5437621792
Pushed a fix for the cancelled unit-test legs, @DanielLeens. They weren't cancelled by the connector-IT failures — they hit the 90-minute job timeout. Six existing tests in TaskExecutionServiceTest were ending up FAILED instead of FINISHED and then waiting out their full Awaitility timeout. The cause was the getClassLoaders() guard from the last round. The guard itself is correct, but the test helper was only registering a class loader for the first task in a group. So tests deploying two tasks left the second one without an entry. That was previously hidden because the missing entry just resulted in a null context class loader. deployTask() registers one per task, so I updated the helper to mirror that. Locally, TaskExecutionServiceTest and TaskDeployStaleContextRaceTest are now 17/17 green, and the tests complete in about 16s instead of 80s. I also checked the other two candidates: removing the synchronized (TaskExecutionService.this) block didn't change the failures, while removing the recycleClassLoader call on the stale path caused a hang instead. @waterWang — also worth noting for #11757: its unit-test job was skipped, so this issue wouldn't have been caught there either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
