SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5628887314
Following up on the SensorsData factory-validation slice raised earlier in this thread. Status is unchanged: the slice is still available, with the one correction already noted here. `server_url` has no default and is consumed directly by the SDK config, so it should be registered as required with a nonblank constraint. `consumer` keeps its existing `batch` default, so it should be registered as optional, and the current console and batch semantics must be preserved exactly. Please do not add format, SDK, or remote checks in this slice. Remaining asks before the PR is opened: - Post a short confirmation here that the required/optional split above is what will be implemented, so the tracker reflects the corrected contract rather than the original wording of the claim. - Keep it to one connector-sensorsdata PR against dev, containing only the factory option registration and validation change. - Include focused factory-level tests for a valid config, missing `server_url`, empty `server_url`, whitespace-only `server_url`, and omitted `consumer` falling back to the `batch` default. - Update the EN/ZH connector docs so they match the option contract (required `server_url`, optional `consumer` with `batch` default). The newer claims from @1328837476-hug and @yigitcan-ozturk are separate from the SensorsData slice and will be answered in their own follow-up rather than mixed into this one. <!-- streview-comment:959 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
