SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5642917635
@1328837476-hug, thanks — the GoogleFirestore sink slice is yours, and the Druid claim is released (no Druid PR needed, as that validation is already in dev via ea07c4bcb0b). The contract you posted matches what we want: - `project_id`: required, nonblank - `collection`: required, nonblank - `credentials`: optional; omission stays valid, explicitly empty or whitespace-only value is rejected Remaining asks before/when you open the PR: 1. Keep the change limited to connector-google-firestore; no credential parsing, format, SDK, or remote checks, and no runtime behavior changes. 2. Add factory-level regression tests covering: missing and blank `project_id`/`collection`, omitted `credentials`, blank/whitespace `credentials`, a valid configuration, and unknown-option validation. 3. Update the matching EN and ZH documentation for the option semantics. 4. Rebase onto the latest dev immediately before opening the PR, then link it back to #11007 here so the tracking table can be updated. Once the PR is up, please post the link in this thread and I'll take a look. <!-- streview-comment:981 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
